Merged
Conversation
Collaborator
|
Thank you for contributing! This is a great fix! |
itsRevela
added a commit
to itsRevela/MinecraftConsoles
that referenced
this pull request
Mar 23, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
itsRevela
added a commit
to itsRevela/MinecraftConsoles
that referenced
this pull request
Mar 23, 2026
itsRevela
pushed a commit
to itsRevela/MinecraftConsoles
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes any debug options from being used in a server (such as craft anything)
Changes
Previous Behavior
No guards behind PlayerConnection::handleDebugOptions were in place, so if compiled as release, players could use debug options such as Craft Anything in a server, including other peoples servers (due to no check)
New Behavior
A guard now exists to prevent debug options from being used if not debug.
Fix Implementation
Added
#ifdef _DEBUGguards around theplayer->SetDebugOptions(packet->m_uiVal);to prevent debug options from being usedThis does not break debug options if compiled as debug, still can use debug options in a local server when compiled as debug as intended.
Minecraft.Client_nEVGfCBTQi.mp4
AI Use Disclosure
no ai
Related Issues